Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data issues #25

Open
mireille-raad opened this issue Aug 20, 2018 · 5 comments
Open

data issues #25

mireille-raad opened this issue Aug 20, 2018 · 5 comments

Comments

@mireille-raad
Copy link
Contributor

Here are some possible data issues. I will be creating one comment per possible issue and give examples.

@mireille-raad
Copy link
Contributor Author

https://birms.bandung.go.id/beta/api/newcontract/ocds-afzrfb-b-2016-38914

The award titles/date/suppliers/values are the same. The only difference is award Id. Same documents has ~9 awards that look largely the same.

screen shot 2018-08-20 at 6 49 12 pm

@mireille-raad
Copy link
Contributor Author

https://birms.bandung.go.id/beta/api/newcontract/ocds-afzrfb-b-2016-43158

Way too many awards/contract per one document... 125 awards and 120 contracts... it could be legit...but worth flagging.

screen shot 2018-08-20 at 6 51 25 pm

@bdgcoder
Copy link
Contributor

bdgcoder commented Sep 1, 2018

#25 (comment)

I already check this data from query and the application. The Direct Procurement have been separate to many contract with the same value and the same company.

@bdgcoder
Copy link
Contributor

bdgcoder commented Sep 1, 2018

#25 (comment)

After update with new CustomDtoArrayValidator.php have an error like this:
Arrays with duplicate values are not allowed when "uniqueItems" is true.

I mean we have 1 planning, and separate awards and each award have items. How to do that on the ocstandard?

 

@mpostelnicu
Copy link
Member

@bdgcoder the contract in question works now without errors https://birms.bandung.go.id/beta/api/newcontract/ocds-afzrfb-b-2016-43158 the error was resolved when u added the DISTINCT keyword , this was committed for another issue. so there are no validation problems now here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants