[17.0][MIG] account_multicurrency_revaluation #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- getting rid of validation because rate will always be at least '1.0' because of (res.currency)_get_rates query - create just one Journal Entry per Currency Revaluation run depending the account type
Currently translated at 98.8% (80 of 81 strings) Translation: account-closing-12.0/account-closing-12.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-12-0/account-closing-12-0-account_multicurrency_revaluation/es/
Currently translated at 100.0% (81 of 81 strings) Translation: account-closing-12.0/account-closing-12.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-12-0/account-closing-12-0-account_multicurrency_revaluation/es/
The override of res.currency _get_conversion_rate did return 1.0 / from_currency.rate when 'revaluation' was True in context. However, as res.currency.rate is defined per company and the context is only used for a computation to the company currency, the std method from odoo will also return 1.0 / from_currency.rate, because to_currency is the company currency. (https://github.com/odoo/odoo/blob/11.0/odoo/addons/base/res/res_currency.py#L179) Therefore, we do not need this override.
This line was already commented in v7.0, so we do not need to keep it across all versions
Currently translated at 100.0% (81 of 81 strings) Translation: account-closing-12.0/account-closing-12.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-12-0/account-closing-12-0-account_multicurrency_revaluation/fr/
Currently translated at 100.0% (80 of 80 strings) Translation: account-closing-13.0/account-closing-13.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-13-0/account-closing-13-0-account_multicurrency_revaluation/es_AR/
Currently translated at 7.5% (6 of 80 strings) Translation: account-closing-13.0/account-closing-13.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-13-0/account-closing-13-0-account_multicurrency_revaluation/zh_CN/
Currently translated at 100.0% (82 of 82 strings) Translation: account-closing-13.0/account-closing-13.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-13-0/account-closing-13-0-account_multicurrency_revaluation/es_AR/
* Odoo 14.0 changes that impact this module are in below commit.
* odoo/odoo@caeb782
* `process_reconciliation` has been changed to `reconcile`, and
`balance` (positive for debit > credit) is used instead of debit+credit;
* Bank Journal should have suspense account.
Currently translated at 4.8% (4 of 82 strings) Translation: account-closing-15.0/account-closing-15.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-15-0/account-closing-15-0-account_multicurrency_revaluation/it/
Currently translated at 4.8% (4 of 82 strings) Translation: account-closing-15.0/account-closing-15.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-15-0/account-closing-15-0-account_multicurrency_revaluation/it/
Two-sided relation between lines created and original ones
…nciled items If the origin line that will be revaluated has partially reconciled items, adjust the values to the real ones.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-closing-16.0/account-closing-16.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_multicurrency_revaluation/
Currently translated at 100.0% (110 of 110 strings) Translation: account-closing-16.0/account-closing-16.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_multicurrency_revaluation/es/
Co-authored-by: Alexis de Lattre <[email protected]>
Currently translated at 100.0% (110 of 110 strings) Translation: account-closing-16.0/account-closing-16.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_multicurrency_revaluation/sv/
Currently translated at 100.0% (110 of 110 strings) Translation: account-closing-16.0/account-closing-16.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_multicurrency_revaluation/sv/
Currently translated at 99.0% (109 of 110 strings) Translation: account-closing-16.0/account-closing-16.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_multicurrency_revaluation/it/
Currently translated at 99.0% (109 of 110 strings) Translation: account-closing-16.0/account-closing-16.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_multicurrency_revaluation/it/
Currently translated at 100.0% (110 of 110 strings) Translation: account-closing-16.0/account-closing-16.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_multicurrency_revaluation/fa/
Currently translated at 10.0% (11 of 110 strings) Translation: account-closing-16.0/account-closing-16.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_multicurrency_revaluation/hr/
Currently translated at 26.3% (29 of 110 strings) Translation: account-closing-16.0/account-closing-16.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_multicurrency_revaluation/hr/
Currently translated at 100.0% (110 of 110 strings) Translation: account-closing-16.0/account-closing-16.0-account_multicurrency_revaluation Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_multicurrency_revaluation/it/
[IMP] fix settings view, demo data, tests, wizard post. [IMP] naming, structure according to dev guidelines. [IMP] remove old readme, readonly from model fields.
Qlasta
commented
Aug 29, 2024
| created_entries.write(vals) | ||
| if self.journal_id.company_id.auto_post_entries: | ||
| for entry in created_entries: | ||
| entry.action_post() |
There was a problem hiding this comment.
fixed error:
File "/mnt/data/odoo-addons-dir/account_multicurrency_revaluation/wizard/wizard_reverse_currency_revaluation.py", line 77, in reverse_revaluate_currency
entry.post()
AttributeError: 'account.move' object has no attribute 'post'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate v16.0 to v17.0, with fix
reverse_revaluate_currencywizard post.