[CHG] *_online_import: empty statements make no sense anymore

As journal_id is now computed from statement lines, we do not want to create
statements without lines, that will not be linked to a journal

account_statement_import_online/i18n/account_statement_import_online.pot

@@ -29,11 +29,6 @@ msgstr ""
 msgid "Active"
 msgstr ""
 
-#. module: account_statement_import_online
-#: model:ir.model.fields,field_description:account_statement_import_online.field_online_bank_statement_provider__allow_empty_statements
-msgid "Allow empty statements"
-msgstr ""
-
 #. module: account_statement_import_online
 #: model:ir.model.fields,field_description:account_statement_import_online.field_online_bank_statement_provider__api_base
 msgid "Api Base"

account_statement_import_online/i18n/it.po

@@ -32,11 +32,6 @@ msgstr ""
 msgid "Active"
 msgstr ""
 
-#. module: account_statement_import_online
-#: model:ir.model.fields,field_description:account_statement_import_online.field_online_bank_statement_provider__allow_empty_statements
-msgid "Allow empty statements"
-msgstr ""
-
 #. module: account_statement_import_online
 #: model:ir.model.fields,field_description:account_statement_import_online.field_online_bank_statement_provider__api_base
 msgid "Api Base"

account_statement_import_online/i18n/nl.po

@@ -32,11 +32,6 @@ msgstr "Actie vereist"
 msgid "Active"
 msgstr "Actief"
 
-#. module: account_statement_import_online
-#: model:ir.model.fields,field_description:account_statement_import_online.field_online_bank_statement_provider__allow_empty_statements
-msgid "Allow empty statements"
-msgstr ""
-
 #. module: account_statement_import_online
 #: model:ir.model.fields,field_description:account_statement_import_online.field_online_bank_statement_provider__api_base
 msgid "Api Base"

account_statement_import_online/models/online_bank_statement_provider.py

@@ -94,7 +94,6 @@ class OnlineBankStatementProvider(models.Model):
     certificate_public_key = fields.Text()
     certificate_private_key = fields.Text()
     certificate_chain = fields.Text()
-    allow_empty_statements = fields.Boolean()
 
     _sql_constraints = [
         (
@@ -227,7 +226,7 @@ def _create_or_update_statement(
             statement_date_since,
             statement_date_until,
         )
-        if not filtered_lines and not self.allow_empty_statements:
+        if not filtered_lines:
             return
         if filtered_lines:
             statement_values.update(

account_statement_import_online/tests/test_account_bank_statement_import_online.py

@@ -447,43 +447,6 @@ def test_dont_create_empty_statements(self):
         self.assertEqual(statements[1].balance_end, 200)
         self.assertEqual(len(statements[1].line_ids), 1)
 
-    def test_create_empty_statements(self):
-        """Test creating empty bank statements
-        ('Allow empty statements' field is check at the provider level).
-        """
-        journal = self._make_journal()
-        provider = self._make_provider(journal)
-        provider.allow_empty_statements = True
-        with mock.patch(mock_obtain_statement_data) as mock_data:
-            mock_data.side_effect = [
-                self._get_statement_line_data(date(2021, 8, 10)),
-                ([], {}),  # August 8th, doesn't have statement
-                ([], {}),  # August 9th, doesn't have statement
-                self._get_statement_line_data(date(2021, 8, 13)),
-            ]
-            provider._pull(datetime(2021, 8, 10), datetime(2021, 8, 14))
-        statements = self.AccountBankStatement.search(
-            [("journal_id", "=", journal.id)], order="name"
-        )
-        # 4 Statements: 2 with movements and 2 empty
-        self.assertEqual(len(statements), 4)
-        # With movement
-        self.assertEqual(statements[0].balance_start, 0)
-        self.assertEqual(statements[0].balance_end, 100)
-        self.assertEqual(len(statements[0].line_ids), 1)
-        # Empty
-        self.assertEqual(statements[1].balance_start, 100)
-        self.assertEqual(statements[1].balance_end, 100)
-        self.assertEqual(len(statements[1].line_ids), 0)
-        # Empty
-        self.assertEqual(statements[2].balance_start, 100)
-        self.assertEqual(statements[2].balance_end, 100)
-        self.assertEqual(len(statements[2].line_ids), 0)
-        # With movement
-        self.assertEqual(statements[3].balance_start, 100)
-        self.assertEqual(statements[3].balance_end, 200)
-        self.assertEqual(len(statements[3].line_ids), 1)
-
     def _make_journal(self):
         """Create a journal for testing."""
         journal = self.AccountJournal.create(

account_statement_import_online/views/online_bank_statement_provider.xml

@@ -84,7 +84,6 @@
                         <group name="configuration" string="Configuration">
                             <field name="statement_creation_mode" />
                             <field name="tz" />
-                            <field name="allow_empty_statements" />
                         </group>
                     </group>
                 </sheet>