Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_statement_import_online: Migration to 16.0 #548

Merged
merged 29 commits into from
Oct 18, 2023

Conversation

NL66278
Copy link
Contributor

@NL66278 NL66278 commented Jan 17, 2023

This builds on the migration of the base modules here: #535

Update: PR 575 was closed in favour of this that has been merged: #575

@NL66278 NL66278 force-pushed the 16.0-mig-account_statement_import_online branch 3 times, most recently from b90fae0 to ebf1186 Compare January 30, 2023 16:44
@NL66278 NL66278 force-pushed the 16.0-mig-account_statement_import_online branch from c6f78ba to b22f6d2 Compare March 7, 2023 14:28
@NL66278
Copy link
Contributor Author

NL66278 commented Mar 9, 2023

@MiquelRForgeFlow Everything green now after updating test and rebasing. Could you have a fresh look?

@NL66278 NL66278 force-pushed the 16.0-mig-account_statement_import_online branch 8 times, most recently from db7cfde to 212d90f Compare March 15, 2023 23:39
@NL66278 NL66278 force-pushed the 16.0-mig-account_statement_import_online branch from 23e61b2 to 0273bf5 Compare April 4, 2023 12:08
requirements.txt Outdated
@@ -1,2 +1,3 @@
# generated from manifests external_dependencies
ofxparse
odoo-test-helper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MiquelRForgeFlow I changed this now. Thanks!

@NL66278 NL66278 force-pushed the 16.0-mig-account_statement_import_online branch 3 times, most recently from 0192cc1 to 61d4941 Compare April 4, 2023 13:00
@StefanRijnhart
Copy link
Member

/ocabot migration account_statement_import_online

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Apr 19, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 19, 2023
13 tasks
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

NL66278 and others added 17 commits September 29, 2023 18:52
1. Find partner if ther already is a bank account with the right IBAN;
2. Store (and display) raw import data to help in problem determination;
3. Make it easy to extend the parsing of import data;
4. Apply some clean coding principles.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_online
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_online/
…port tests at install

Installing this module failed because `mock` couldn't be found. Indeed there was a migration problem.

However, I was not testing the module; just installing. At install, tests shouldn't be imported.

This file was being imported because the dummy model was expected to exist in database for tests. Using odoo-test-helper for that now.

@moduon MT-295
The 2 modules account_statement_import_online and
account_statement_import depend on account_statement_import_base (and
not on each other) and share common code, in particular a hook to update
the statement line. So we can now have reconciliation modules that use
this hook and therefore work both on file import and online import. More
details on OCA#481.

Improve bank statement line form view and journal form view.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_online
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_online/
Currently translated at 25.5% (24 of 94 strings)

Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_online
Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_online/it/
@NL66278 NL66278 force-pushed the 16.0-mig-account_statement_import_online branch from 8022ca9 to 9b7928e Compare September 29, 2023 16:53
@bhaveshselarka
Copy link

@NL66278 @StefanRijnhart Any idea when it will be merge into 16.0 ?

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-548-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a90aa83 into OCA:16.0 Oct 18, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8388678. Thanks a lot for contributing to OCA. ❤️

victoralmau pushed a commit to Tecnativa/bank-statement-import that referenced this pull request Apr 4, 2024
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.