-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] account_statement_import_online: Migration to 16.0 #548
[16.0][MIG] account_statement_import_online: Migration to 16.0 #548
Conversation
b90fae0
to
ebf1186
Compare
c6f78ba
to
b22f6d2
Compare
@MiquelRForgeFlow Everything green now after updating test and rebasing. Could you have a fresh look? |
db7cfde
to
212d90f
Compare
23e61b2
to
0273bf5
Compare
requirements.txt
Outdated
@@ -1,2 +1,3 @@ | |||
# generated from manifests external_dependencies | |||
ofxparse | |||
odoo-test-helper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see https://github.com/OCA/bank-statement-import/blob/15.0/test-requirements.txt, it should go in test-requirements.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MiquelRForgeFlow I changed this now. Thanks!
0192cc1
to
61d4941
Compare
/ocabot migration account_statement_import_online |
account_statement_import_online/models/online_bank_statement_provider.py
Show resolved
Hide resolved
This PR has the |
1. Find partner if ther already is a bank account with the right IBAN; 2. Store (and display) raw import data to help in problem determination; 3. Make it easy to extend the parsing of import data; 4. Apply some clean coding principles.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_online Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_online/
…port tests at install Installing this module failed because `mock` couldn't be found. Indeed there was a migration problem. However, I was not testing the module; just installing. At install, tests shouldn't be imported. This file was being imported because the dummy model was expected to exist in database for tests. Using odoo-test-helper for that now. @moduon MT-295
The 2 modules account_statement_import_online and account_statement_import depend on account_statement_import_base (and not on each other) and share common code, in particular a hook to update the statement line. So we can now have reconciliation modules that use this hook and therefore work both on file import and online import. More details on OCA#481. Improve bank statement line form view and journal form view.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_online Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_online/
Currently translated at 25.5% (24 of 94 strings) Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_online Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_online/it/
8022ca9
to
9b7928e
Compare
@NL66278 @StefanRijnhart Any idea when it will be merge into 16.0 ? |
account_statement_import_online/models/online_bank_statement_provider.py
Outdated
Show resolved
Hide resolved
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 8388678. Thanks a lot for contributing to OCA. ❤️ |
This builds on the migration of the base modules here: #535
Update: PR 575 was closed in favour of this that has been merged: #575