[WIP] [16.0] mig account_statement_import_online* combined #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also Rename account_bank_statement_import_online => account_statement_import_online
…f online.bank.statement.provider: avoid speading the information on 3 tabs. As there are just a few fields, let's keep all the information directly visible. Fix warning on search view of online.bank.statement.provider Fix some tests Button on journal form view to access the wizard The wizard now returns the bank statements of the journal(s) Fix wired strings
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_online Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_online/
Currently translated at 26.6% (24 of 90 strings) Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_online Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_online/it/
1. Find partner if ther already is a bank account with the right IBAN; 2. Store (and display) raw import data to help in problem determination; 3. Make it easy to extend the parsing of import data; 4. Apply some clean coding principles.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_online Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_online/
…port tests at install Installing this module failed because `mock` couldn't be found. Indeed there was a migration problem. However, I was not testing the module; just installing. At install, tests shouldn't be imported. This file was being imported because the dummy model was expected to exist in database for tests. Using odoo-test-helper for that now. @moduon MT-295
The 2 modules account_statement_import_online and account_statement_import depend on account_statement_import_base (and not on each other) and share common code, in particular a hook to update the statement line. So we can now have reconciliation modules that use this hook and therefore work both on file import and online import. More details on OCA#481. Improve bank statement line form view and journal form view.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_online Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_online/
Currently translated at 25.5% (24 of 94 strings) Translation: bank-statement-import-15.0/bank-statement-import-15.0-account_statement_import_online Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-15-0/bank-statement-import-15-0-account_statement_import_online/it/
1. Find partner if ther already is a bank account with the right IBAN; 2. Store (and display) raw import data to help in problem determination; 3. Make it easy to extend the parsing of import data; 4. Apply some clean coding principles.
Currently translated at 100.0% (16 of 16 strings) Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_online_ponto Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_online_ponto/ca/
The 2 modules account_statement_import_online and account_statement_import depend on account_statement_import_base (and not on each other) and share common code, in particular a hook to update the statement line. So we can now have reconciliation modules that use this hook and therefore work both on file import and online import. More details on OCA#481. Improve bank statement line form view and journal form view.
Separate retrieval of data from ponto (buffer data) and creation of statements.
Add debug messages Set raw_data in bank statement lines
With Ponto we can only retrieve data backwards in time. Therefore we override the normal _pull method to create statements in descending order of statement date.
NL66278
force-pushed
the
16.0-mig-account_statement_import_online-combined
branch
from
ca19117 to
f5073d9
Compare
|
A migration PR already exists for I think we should first review it, test it and suggest the necessary changes to merge it; once it is merged maybe the best thing to do is to create several PRs (one per module): |
|
@victoralmau I intend to close this PR soon. My first attempt to migrate the online import, together with import of ponto module caused problems with migrating other modules. I used the combined branch to check the compatibility with other migrations. Basically that seems to be solved now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure migration of account_statement_import_online compatible with other migrated modules besides ponto.