Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Licence to LGPL #56

Open
BT-mfasola opened this issue Jun 8, 2020 · 5 comments
Open

Change Licence to LGPL #56

BT-mfasola opened this issue Jun 8, 2020 · 5 comments

Comments

@BT-mfasola
Copy link

Hi @pedrobaeza

We would like to contribute to and build on a base ecommerce connector that would allow to use different implementations and different shops at the same time.

Because some details of specific implementations might be very shop-specific and not of public use, we don't think AGPL-3 would be a suitable licence.

If you could change the licence, we will consider building and contributing a shopware connector in V12 & V13

@pedrobaeza
Copy link
Member

Which module are you talking about? Anyway, the ones that should grant the license change are the contributors of that module, not me (although if I'm one of that contributors), I can agree in principle.

@BT-mfasola
Copy link
Author

Hello @pedrobaeza
That's a valid point. Currently I only see one module and the contributor's list on the repo results in a 404...
We see that both existing connectors that build on this base (magento, presta-shop) are quite dated. We thought it might be reasonable to have a common base for different shops if in a scenario someone wants to connect different shops, but we're not sure if this is the right place.

@pedrobaeza
Copy link
Member

I think @guewen is the main contributor of the module.

@guewen
Copy link
Member

guewen commented Jun 10, 2020

Hi @BT-mfasola,

I'm one of the main contributors of the module, but this one has a very long history, dating back to the "extra-addons" era where it was named "base_sale_multichannels". Renamed here: b197ba8

This new incarnation was mainly written during a code sprint where we adapted it to work on top of the new bricks of the "connector" framework in order to build the "new" magento connector.

We can see the history after the renaming on these pages:

With several authors at the beginning: @jgrandguillaume, @gurneyalex, @sebastienbeau, @bealdav and me.

Personally, I'm ok with a license change to LGPL. From the OCA standpoint, I don't know if my agreement is enough or if the other initial authors have to approve too.

@bealdav
Copy link
Member

bealdav commented Jun 10, 2020

+ 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants