Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WorkContext.env customize-able and propagate-able #465

Open
simahawk opened this issue Jun 20, 2023 · 3 comments
Open

Make WorkContext.env customize-able and propagate-able #465

simahawk opened this issue Jun 20, 2023 · 3 comments
Labels
enhancement no stale Use this label to prevent the automated stale action from closing this PR/Issue.

Comments

@simahawk
Copy link
Contributor

ATM the env of the WorkContext comes from the collection.
This is sub-optimal because you cannot customize it for specific cases (eg: by setting a ctx key before calling a method).

Proposal: self.env should be assigned on __init__ and got from kw args. Defaults to collection.env if not available.
It should be added to propagate-able args too.

Copy link

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 17, 2023
@simahawk simahawk added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Dec 18, 2023
@simahawk
Copy link
Contributor Author

@guewen may I ask your feedback on this?

@guewen
Copy link
Member

guewen commented Aug 6, 2024

Hey, it was definitely something that bothered me at some point and wanted to improve.
I remember fiddling with it at some point but did not reach a working/mature solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

No branches or pull requests

2 participants