[17.0] partner_firstname: _check_name exception during saving address in website checkout form

[janbec]

Module

partner_firstname
There are two more bug reports #1638 and #1830 describing similar errors with different error messages.

Describe the bug

• I logged in as a portal user and added something to my shopping cart
• click on checkout and you get to this site:
  
• When I hit "Adresse speichern" ("Save Address"), I get the following error:
  

This is the translation of the error given by _check_name .

It seems both values firstname and lastname are false. It looks like _checkout_form_save writes to the partner with None values for firstname and lastname:

checkout in checkout_form_save() is a dict with partner values in this case. The issue is fixed if I write firstname and lastname into checkout during that method, but there is probably a better way to do this.

To Reproduce

17.0 (I just pulled the most recent version)

Steps to reproduce the behavior:

1. Get access and login with a portal user
2. put something into a shopping cart
3. try to checkout
4. Fill out address field and click save
5. Error