Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sale_force_invoiced: set amount_to_invoice to zero #3093

Open
alessandro-fiorino opened this issue Apr 23, 2024 · 3 comments
Open

sale_force_invoiced: set amount_to_invoice to zero #3093

alessandro-fiorino opened this issue Apr 23, 2024 · 3 comments
Labels
enhancement

Comments

@alessandro-fiorino
Copy link
Contributor

The sale_force_invoiced module just updates the invoice_status to invoiced.
It should also set the amount_to_invoice to zero on the lines to be more consistent, without that for example the sale_order_amount_to_invoice module shows non-zero amount to invoice values for "fully invoiced" orders, which can confuse the user.
@legalsylvain
Copy link
Contributor

Makes sense, could you make a PR ?

@alessandro-fiorino alessandro-fiorino mentioned this issue Apr 25, 2024
Merged
@alessandro-fiorino
Copy link
Contributor Author

Just did it!

@alessandro-fiorino
Copy link
Contributor Author

@legalsylvain would you review it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@legalsylvain @alessandro-fiorino