Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] sign_oca: Some fixes #18

Merged
merged 1 commit into from
Mar 5, 2024
Merged

[14.0][FIX] sign_oca: Some fixes #18

merged 1 commit into from
Mar 5, 2024

Conversation

PauBForgeFlow
Copy link

  1. Add Sign button in request form (it was only in tree view).
  2. Fix configure template action when it is created from a request.

@OCA-git-bot
Copy link
Contributor

Hi @etobella,
some modules you are maintaining are being modified, check this out!

@PauBForgeFlow PauBForgeFlow mentioned this pull request Feb 27, 2024
Merged
etobella
etobella requested changes Feb 27, 2024
View reviewed changes
@PauBForgeFlow PauBForgeFlow force-pushed the 14.0-fix-sign_oca_2 branch 3 times, most recently from bd160af to dc933c3 Compare February 28, 2024 10:29
@pedrobaeza
Copy link
Member

Can you rebase?

@PauBForgeFlow @AlexPForgeFlow
[FIX] sign_oca: Some fixes
3a807ee 
1. Add Sign button in request form (it was only in tree view).
2. Fix configure template action when it is created from a request.
pedrobaeza
pedrobaeza approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-18-by-pedrobaeza-bump-minor, awaiting test results.

@pedrobaeza pedrobaeza added this to the 14.0 milestone Mar 5, 2024
@pedrobaeza
Copy link
Member

@etobella I have launched the merge command as your requests were attended.

@OCA-git-bot OCA-git-bot merged commit 7c7a030 into OCA:14.0 Mar 5, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 88c759c. Thanks a lot for contributing to OCA. ❤️

@PauBForgeFlow PauBForgeFlow mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau left review comments

@etobella etobella etobella requested changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@BernatPForgeFlow BernatPForgeFlow BernatPForgeFlow approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
6 participants
@PauBForgeFlow @OCA-git-bot @pedrobaeza @victoralmau @etobella @BernatPForgeFlow