Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] sign_oca: Use flex in order to show it properly #50

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

etobella
Copy link
Member

@etobella etobella commented Jul 7, 2024

Fixes #43
The same happened with the configuration

@etobella
Copy link
Member Author

etobella commented Jul 7, 2024

@TheClaud99 can you check in runboat?

@etobella
Copy link
Member Author

etobella commented Jul 7, 2024

It affects 14 and 15 too. Once it is merged I will back port it

@hitrosol
Copy link

hitrosol commented Jul 8, 2024

I can't see the runboat link :)

@etobella
Copy link
Member Author

etobella commented Jul 8, 2024

I can't see the runboat link :)

@hitrosol You can check it now 😄

@pedrobaeza pedrobaeza changed the title [IMP] sign_oca: Use flex in order to show it properly [16.0][IMP] sign_oca: Use flex in order to show it properly Jul 8, 2024
@pedrobaeza pedrobaeza added this to the 16.0 milestone Jul 8, 2024
@pedrobaeza
Copy link
Member

Do you have screenshot of the before/after?

@etobella
Copy link
Member Author

etobella commented Jul 8, 2024

Before:

image

After:

image

You can see the end of the frame on the after

@etobella etobella linked an issue Jul 8, 2024 that may be closed by this pull request
Copy link

@hitrosol hitrosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can access the runboat now, but when I try to sign the doc, the response of the signature box is very slow. It's faster when I tried in my local, and it successfully signed and validated.

@etobella
Copy link
Member Author

etobella commented Jul 9, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-50-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a582ecc into OCA:16.0 Jul 9, 2024
7 checks passed
@OCA-git-bot
Copy link

Congratulations, your PR was merged at a582ecc. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[16.0][BUG] PDF Viewer Header Overlap Issue
4 participants