Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] spreadsheet_oca: Show data only on debug mode. Otherwise it is confusing for users #52

Merged
merged 1 commit into from
Oct 25, 2024
Merged

[16.0][IMP] spreadsheet_oca: Show data only on debug mode. Otherwise it is confusing for users #52

merged 1 commit into from
Oct 25, 2024

Conversation

etobella
Copy link
Member

Users might try to upload an XLSX file at it doesn't work

@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 25, 2024
pedrobaeza
pedrobaeza approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-52-by-pedrobaeza-bump-minor, awaiting test results.

@pedrobaeza
Copy link
Member

FYI, I put via base_technical_features the technical permission to everyone, as if not, there are a lot of valid fields that they don't see.

@OCA-git-bot OCA-git-bot merged commit 36f002d into OCA:16.0 Oct 25, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a835a1d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@etobella @OCA-git-bot @pedrobaeza