[FIX] Make check in quant level so that it works in manufacturing as well #256
Conversation
| def _quant_create(self, qty, move, lot_id=False, owner_id=False, | ||
| src_package_id=False, dest_package_id=False, | ||
| force_location_from=False, force_location_to=False): | ||
| if move.product_id.check_no_negative \ |
There was a problem hiding this comment.
You are not checking here if qty is negative.
There was a problem hiding this comment.
_quant_create is called when negative otherwise _quant_split is called.
yes it is not self explanatory but it works like a charm.
There was a problem hiding this comment.
OK, I see, please document it then properly, indicating that always that this method is called and the location is internal, a negative quant is created.
|
You have to rebase your branch. |
|
Yes I admit, I am very bad at using git. |
|
I have checked today that |
|
Why don't you simply use the approach on #137? |
|
move.location_id.usage == 'internal' prevents it in material receive, but I agree with you that #137 seems to be a cleaner solution. stock_no_negative and stock_disallow_negative both doing the same thing. Do you think it is a good idea to copy the same thing from stock_disallow_negative into stock_no_negative? I know it is not a good idea to have two modules doing the same thing but perhaps it's better to remove stock_no_negative and use stock_disallow_negative. Let me know what you think so that i can proceed. |
|
The other PR can be disregarded with this one. They serve the same purpose, so better to include that here that is already in the repository. |
|
@levkar Hello, do you still plan to work on this PR ? Is it still useful ? |
|
3 PR's are very related,
If you can decide on how to proceed I would be happy to help. Hopefully we can close all three PR's. |
This is simpler way to have the same functionality and works well with any kind of move (such as manufacturing moves).