[10.0] Module stock_no_negative #275
Conversation
|
We'll add test cases to this PR, and also backport to 9.0 |
| <field name="inherit_id" ref="stock.view_template_property_form" /> | ||
| <field name="arch" type="xml"> | ||
| <field name="categ_id" position="after"> | ||
| <field name="allow_negative_stock" |
There was a problem hiding this comment.
I think that this field should only be accessible to a specific security group. You basically prevent negative stocks, but allow any user to override this rule just going to the product and changing it. What do you think?
There was a problem hiding this comment.
Only few users should have write access on products... as a lot of parameters on products are sensitive, not only this one !
| # @author Alexis de Lattre <[email protected]> | ||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
|
||
| from odoo import models, api, _ |
There was a problem hiding this comment.
Why should I change import order ?
There was a problem hiding this comment.
https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#imports
alphabetically ordered. Details but convention ;-)
There was a problem hiding this comment.
Arf !!! Incredible ! Don't count on me to apply these crazy coding conventions !
|
Is this module ready to be merged? |
|
@sebalix yes, of course. I've been using it in production for several months. |
|
@pedrobaeza this one can be merged |
|
Maybe you can clean a bit the commits? |
|
Should this module be tested separately or other module's tests should ensure non zero stock level ? |
|
See comment #341 (comment) |
|
Works like a charm |
|
Setup : akretion#3 |
|
We have arrived to the conclusion after some analysis, for the good health of the repository, that the better approach to proceed with this topic is the following: In the config.settings of Stock, you have to select an option to activate the stock_no_negative after the installation of the module. In the Readme is put a configuration note that after the installation, you have to select that option if you want to use the module. We have developed a patch with this approach for v9, and we will open the PR soon. If you like, you may want to cherry-pick it here. |
|
To add to the point of @mreficent , the tests of module 'stock_no_negative' will activate this setting, and then proceed to do the tests. The change in config.settings should create an entry in ir_config_parameter with name 'stock_no_negative' and value 'True'. If the parameter does not exist, or is False, then it is assumed that the negative stocks are allowed, regardless if the products have been set with allow_negative = False. |
|
That's not needed: you just need to deactivate the check if in test mode and you are not explicitly testing this module (which is done through a context key). Check https://github.com/OCA/bank-payment/blob/43f8723f8cb4d8defc50d53e83f8b523a7560f00/account_payment_transfer_reconcile_batch/models/bank_payment_line.py#L28 for an example on how to do it |
|
@pedrobaeza we will do that way now, thanks! |
|
Done. @alexis-via please, can you cherry-pick commit 73fa871 from #357? |
|
Better wait first to have it finished (although of course it works) |
|
Now you can cherry-pick 73fa871 |
|
Actually disallowing negative stock by default makes more sense in othis module. In v8, we had serious problems with customers because of this behavior and finally we wrote another auto-install module which disallows it by default. There was a PR of a new module named stock_disallow_negative but later author decided to use this module name and cancelled that PR. Same rationale. I would strongly suggest to disallow by default. |
|
But it's already the default behavior in this module AFAIK. |
|
Sorry, I get it wrong. It's just for tests. No problem. |
|
@alexis-via would you be able to clean the commits and cherry-pick 73fa871 for having this module ready to be merged, or should we superseed it? |
pedrobaeza
force-pushed
the
10-stock_no_negative
branch
from
e4a1c14
to
c9e6641
Compare
pedrobaeza
force-pushed
the
10-stock_no_negative
branch
from
c9e6641
to
77c4682
Compare
This is in fact a port to v10 of my PR #137 but changing the name to stock_no_negative, because there is already an OCA module with that name in older versions.