Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using metadata-action for Docker image tags #120

Open
mikegerber opened this issue Oct 29, 2024 · 3 comments
Open

Consider using metadata-action for Docker image tags #120

mikegerber opened this issue Oct 29, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@mikegerber
Copy link
Collaborator

https://github.com/docker/metadata-action

This would enable having:

  • semver tags
  • having a latest tag that points to the latest semver'ed image
  • having a branch tag (e.g. "master" for the latest master)
@mikegerber mikegerber self-assigned this Oct 29, 2024
@mikegerber
Copy link
Collaborator Author

👀 @joschrew

This probably needs some discussion w.r.t. what's wanted for OCR-D.

@mikegerber mikegerber added the enhancement New feature or request label Oct 29, 2024
@mikegerber
Copy link
Collaborator Author

(note that this also solves the "latest should not be master but the latest stable" "problem")

@bertsky
Copy link
Contributor

bertsky commented Oct 29, 2024

Good points, but I don't think we should create a dependency on this specific action. Our Docker builds are diversified (CircleCI vs Github Actions, Makefile, labels in Dockerfile) and usually separate build and push. Even just here in ocrd_calamari it would entail lots of changes to use that action.

But providing tags with proper release version and branch in addition to latest would be good. (Also we should add the OCI labels in addition to the old label schema everywhere.)

Recommend moving to spec. (@kba could do it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants