-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fatal Error when step limit reached #1244
Comments
I would like to put a label "Décysif" on such an issue. Why am I not allowed to put labels on issues? |
This should have been fixed in #936 but seems we re-introduced the issue. I am not sure why you can't add labels; I think this needs you to have the "Triage" permission but it does not appear in the list of possible permissions… I gave you "Read" access to the repo in case it would allow me to upgrade to "Triage" but that does not seem possible either. I have added the "decysif" label for this one. |
I still can't modify labels. Never mind, it is not important. |
This is a partial fix for OCamlPro#1244 that only addresses the fatal error issue, but not incrementality.
Turns out the fix in #936 only applies if the step limit is reached while processing an assertion, not while processing
The current semantics of the step limit is that it is a global limit; we only support a per-goal time limit, so any further queries would immediately return The steps limit mechanism was designed when Alt-Ergo supported neither incremental queries nor model generation, and it seems clear that the implementation is no longer satisfactory. I have a fix ( #1245 ) to avoid returning a fatal error; fixing the rest of the issue w.r.t incrementality and model generation after a timeout will require more work. |
This is a partial fix for #1244 that only addresses the fatal error issue, but not incrementality.
When Alt-Ergo reaches the given step bound, an uncaught exception is signaled. It is desirable to display a proper information message and not an error message, this is a perfectly expected potential answer. For example, a SMTLIB-style message
would be perfect. Moreover: we want the prover to continue, and answer to the next query, that could be for example
and get a potential model. I attach a reproducer. Here is the output I get with Alt-Ergo 2.6.0:
The text was updated successfully, but these errors were encountered: