Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a wrapper class that includes data(?), model, and gridsearch #40

Open
JulianBiesheuvel opened this issue Jul 17, 2024 · 1 comment
Assignees
Labels

Comments

@JulianBiesheuvel
Copy link
Collaborator

JulianBiesheuvel commented Jul 17, 2024

With a wrapper class, the user can choose what model they would like to use (for now it only accommodates XGBoost but in the future possibly a neural network), accounts for the grid-search (often the model and the grid-search go together), and the data (t.b.d.). It also provides extra functionalities like saving and loading a model from a file, and more...

  • different kinds of plotting methods
@JulianBiesheuvel JulianBiesheuvel self-assigned this Jul 17, 2024
@JulianBiesheuvel JulianBiesheuvel added the In Progress This issue is currently under investigation label Jul 17, 2024
@JulianBiesheuvel
Copy link
Collaborator Author

JulianBiesheuvel commented Aug 9, 2024

The architecture we discussed—having a parent class Model with child classes XGBoostCustom and MLP—is too simple and not feasible. We should consider a more elaborate approach, as I described earlier. For now, I've implemented the custom XGBoost class with all the necessary features. However, features like saving and loading the model and performing grid search should ideally be part of a wrapper class rather than being included in each individual model. Some features that are currently implemented for the CustomXGBoostRegressor (but should be part of a wrapper), are:

For now, this, and the issues listed above, are on hold. In future releases, a wrapper/parent class will be provided that accounts for different kinds of models. For now, the focus is on the XGBoost model.

@JulianBiesheuvel JulianBiesheuvel removed the In Progress This issue is currently under investigation label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant