Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open3d required in source recon package #193

Open
cgohil8 opened this issue Apr 6, 2023 · 2 comments
Open

open3d required in source recon package #193

cgohil8 opened this issue Apr 6, 2023 · 2 comments
Assignees

Comments

@cgohil8
Copy link
Collaborator

cgohil8 commented Apr 6, 2023

open3d is used in the osl.source_recon package. It needs to be added to the requirements here:

https://github.com/OHBA-analysis/osl/blob/main/setup.py#L11-L17

@cgohil8 cgohil8 assigned cgohil8 and woolrich and unassigned cgohil8 Apr 6, 2023
@cgohil8
Copy link
Collaborator Author

cgohil8 commented Apr 12, 2023

open3d is only used in the visualisation of coreg, specifically only when we include the nose. For the workshop we don't necessarily need this features. Therefore, we decided we will make open3d a soft requirement - i.e. not installed by default by the package and avoid including the nose when plotting the coreg.

@matsvanes
Copy link
Collaborator

matsvanes commented Jan 11, 2024

We can add a decorator to coreg_display to check if open3d has been installed, if not, default include_nose in the coreg plotting to False.

@matsvanes matsvanes assigned cgohil8 and unassigned woolrich Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants