diff --git a/DESCRIPTION b/DESCRIPTION index cb4d26aa..2108ed7b 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,8 +1,8 @@ Package: DataQualityDashboard Type: Package Title: Execute and View Data Quality Checks on OMOP CDM Database -Version: 2.1.1 -Date: 2023-02-27 +Version: 2.1.2 +Date: 2023-03-10 Authors@R: c( person("Katy", "Sadowski", email = "sadowski@ohdsi.org", role = c("aut", "cre")), person("Clair", "Blacketer", role = c("aut")), @@ -12,7 +12,7 @@ Authors@R: c( person("Frank", "DeFalco", role = c("aut")), person("Pavel", "Grafkin", role = c("aut")) ) -Maintainer: Katy Sadowski +Maintainer: Katy Sadowski Description: An R package for assessing data quality in standardized OMOP Common Data Model data sources. License: Apache License (>= 2) VignetteBuilder: knitr diff --git a/NEWS.md b/NEWS.md index 72b19dda..32abec25 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,8 @@ +DataQualityDashboard 2.1.2 +========================== + +1. Fixing bug in cdmDatatype check SQL that was causing NULL values to fail the check. + DataQualityDashboard 2.1.1 ========================== diff --git a/docs/404.html b/docs/404.html index 0cebbf99..99dc270a 100644 --- a/docs/404.html +++ b/docs/404.html @@ -32,7 +32,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/LICENSE-text.html b/docs/LICENSE-text.html index fd6da4a6..4a33c49d 100644 --- a/docs/LICENSE-text.html +++ b/docs/LICENSE-text.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/articles/AddNewCheck.html b/docs/articles/AddNewCheck.html index 2f157200..508a7618 100644 --- a/docs/articles/AddNewCheck.html +++ b/docs/articles/AddNewCheck.html @@ -33,7 +33,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 @@ -105,7 +105,7 @@

Add a New Data Quality Check

Don Torok

-

2023-02-27

+

2023-03-10

Source: vignettes/AddNewCheck.rmd diff --git a/docs/articles/CheckStatusDefinitions.html b/docs/articles/CheckStatusDefinitions.html index 058832a9..885c39a1 100644 --- a/docs/articles/CheckStatusDefinitions.html +++ b/docs/articles/CheckStatusDefinitions.html @@ -33,7 +33,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 @@ -106,7 +106,7 @@

Check Status Descriptions

Dmitry Ilyn

-

2023-02-27

+

2023-03-10

Source: vignettes/CheckStatusDefinitions.rmd diff --git a/docs/articles/CheckTypeDescriptions.html b/docs/articles/CheckTypeDescriptions.html index 57d99ae2..dd23855d 100644 --- a/docs/articles/CheckTypeDescriptions.html +++ b/docs/articles/CheckTypeDescriptions.html @@ -33,7 +33,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 @@ -106,7 +106,7 @@

Data Quality Check Type Definitions

Clair Blacketer

-

2023-02-27

+

2023-03-10

Source: vignettes/CheckTypeDescriptions.rmd diff --git a/docs/articles/DataQualityDashboard.html b/docs/articles/DataQualityDashboard.html index c72cdf7c..737561c6 100644 --- a/docs/articles/DataQualityDashboard.html +++ b/docs/articles/DataQualityDashboard.html @@ -33,7 +33,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 @@ -106,7 +106,7 @@

Getting Started

Clair Blacketer

-

2023-02-27

+

2023-03-10

Source: vignettes/DataQualityDashboard.rmd diff --git a/docs/articles/DqdForCohorts.html b/docs/articles/DqdForCohorts.html index c2bc81d4..5fbf2b27 100644 --- a/docs/articles/DqdForCohorts.html +++ b/docs/articles/DqdForCohorts.html @@ -33,7 +33,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 @@ -106,7 +106,7 @@

Running the DQD on a Cohort

Clair Blacketer

-

2023-02-27

+

2023-03-10

Source: vignettes/DqdForCohorts.rmd diff --git a/docs/articles/Thresholds.html b/docs/articles/Thresholds.html index 89c54d07..58df50bf 100644 --- a/docs/articles/Thresholds.html +++ b/docs/articles/Thresholds.html @@ -33,7 +33,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 @@ -106,7 +106,7 @@

Failure Thresholds and How to Change Them

Clair Blacketer

-

2023-02-27

+

2023-03-10

Source: vignettes/Thresholds.rmd diff --git a/docs/articles/index.html b/docs/articles/index.html index 29cb48f5..30e5171a 100644 --- a/docs/articles/index.html +++ b/docs/articles/index.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/authors.html b/docs/authors.html index 2eaf2618..41e22d66 100644 --- a/docs/authors.html +++ b/docs/authors.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/index.html b/docs/index.html index e0dc89fb..db1a0449 100644 --- a/docs/index.html +++ b/docs/index.html @@ -33,7 +33,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/news/index.html b/docs/news/index.html index fa057a18..13979d16 100644 --- a/docs/news/index.html +++ b/docs/news/index.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 @@ -81,6 +81,10 @@

Changelog

Source: NEWS.md +
+

DataQualityDashboard 2.1.2

+
  1. Fixing bug in cdmDatatype check SQL that was causing NULL values to fail the check.
    2. +

DataQualityDashboard 2.1.1

  1. Updating author list in DESCRIPTION.
    2. diff --git a/docs/pkgdown.yml b/docs/pkgdown.yml index d94c1a77..1805a9ae 100644 --- a/docs/pkgdown.yml +++ b/docs/pkgdown.yml @@ -8,5 +8,5 @@ articles: DataQualityDashboard: DataQualityDashboard.html DqdForCohorts: DqdForCohorts.html Thresholds: Thresholds.html -last_built: 2023-02-27T22:52Z +last_built: 2023-03-10T19:00Z diff --git a/docs/pull_request_template.html b/docs/pull_request_template.html index bc37de7d..26af9528 100644 --- a/docs/pull_request_template.html +++ b/docs/pull_request_template.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2
diff --git a/docs/reference/dot-evaluateThresholds.html b/docs/reference/dot-evaluateThresholds.html index 50d5bab9..8dbbc527 100644 --- a/docs/reference/dot-evaluateThresholds.html +++ b/docs/reference/dot-evaluateThresholds.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/reference/dot-getCheckId.html b/docs/reference/dot-getCheckId.html index 628a28ad..27aa2130 100644 --- a/docs/reference/dot-getCheckId.html +++ b/docs/reference/dot-getCheckId.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/reference/dot-processCheck.html b/docs/reference/dot-processCheck.html index 2b8f9e8f..412e15b5 100644 --- a/docs/reference/dot-processCheck.html +++ b/docs/reference/dot-processCheck.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/reference/dot-recordResult.html b/docs/reference/dot-recordResult.html index 8ea57522..2bd4113a 100644 --- a/docs/reference/dot-recordResult.html +++ b/docs/reference/dot-recordResult.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/reference/dot-runCheck.html b/docs/reference/dot-runCheck.html index c974ed65..c506bb00 100644 --- a/docs/reference/dot-runCheck.html +++ b/docs/reference/dot-runCheck.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/reference/dot-summarizeResults.html b/docs/reference/dot-summarizeResults.html index b913a880..c67febca 100644 --- a/docs/reference/dot-summarizeResults.html +++ b/docs/reference/dot-summarizeResults.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/reference/dot-writeResultsToCsv.html b/docs/reference/dot-writeResultsToCsv.html index 0a8eb13c..3dc592b3 100644 --- a/docs/reference/dot-writeResultsToCsv.html +++ b/docs/reference/dot-writeResultsToCsv.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/reference/dot-writeResultsToJson.html b/docs/reference/dot-writeResultsToJson.html index 1264d0db..290a6990 100644 --- a/docs/reference/dot-writeResultsToJson.html +++ b/docs/reference/dot-writeResultsToJson.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/reference/dot-writeResultsToTable.html b/docs/reference/dot-writeResultsToTable.html index a86a7f35..b1896d7e 100644 --- a/docs/reference/dot-writeResultsToTable.html +++ b/docs/reference/dot-writeResultsToTable.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/reference/executeDqChecks.html b/docs/reference/executeDqChecks.html index 09348aba..ad72ce61 100644 --- a/docs/reference/executeDqChecks.html +++ b/docs/reference/executeDqChecks.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/reference/index.html b/docs/reference/index.html index 12d373dd..20a30acb 100644 --- a/docs/reference/index.html +++ b/docs/reference/index.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/reference/listDqChecks.html b/docs/reference/listDqChecks.html index 00c9d4ec..0c2e89fd 100644 --- a/docs/reference/listDqChecks.html +++ b/docs/reference/listDqChecks.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/reference/reEvaluateThresholds.html b/docs/reference/reEvaluateThresholds.html index 0602bfb5..22f2684d 100644 --- a/docs/reference/reEvaluateThresholds.html +++ b/docs/reference/reEvaluateThresholds.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/reference/viewDqDashboard.html b/docs/reference/viewDqDashboard.html index 605c66f1..df68ea08 100644 --- a/docs/reference/viewDqDashboard.html +++ b/docs/reference/viewDqDashboard.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/reference/writeJsonResultsToCsv.html b/docs/reference/writeJsonResultsToCsv.html index 8c991dcd..7cf139d5 100644 --- a/docs/reference/writeJsonResultsToCsv.html +++ b/docs/reference/writeJsonResultsToCsv.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/docs/reference/writeJsonResultsToTable.html b/docs/reference/writeJsonResultsToTable.html index 90ddab24..23c04951 100644 --- a/docs/reference/writeJsonResultsToTable.html +++ b/docs/reference/writeJsonResultsToTable.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.1.1 + 2.1.2 diff --git a/extras/DataQualityDashboard.pdf b/extras/DataQualityDashboard.pdf index 80804395..613442f5 100644 Binary files a/extras/DataQualityDashboard.pdf and b/extras/DataQualityDashboard.pdf differ diff --git a/inst/doc/AddNewCheck.pdf b/inst/doc/AddNewCheck.pdf index c1291d65..87d2bb58 100644 Binary files a/inst/doc/AddNewCheck.pdf and b/inst/doc/AddNewCheck.pdf differ diff --git a/inst/doc/CheckStatusDefinitions.pdf b/inst/doc/CheckStatusDefinitions.pdf index e5c14b31..ff2740f1 100644 Binary files a/inst/doc/CheckStatusDefinitions.pdf and b/inst/doc/CheckStatusDefinitions.pdf differ diff --git a/inst/doc/CheckTypeDescriptions.pdf b/inst/doc/CheckTypeDescriptions.pdf index 7353eaa5..1c0399d6 100644 Binary files a/inst/doc/CheckTypeDescriptions.pdf and b/inst/doc/CheckTypeDescriptions.pdf differ diff --git a/inst/doc/DataQualityDashboard.pdf b/inst/doc/DataQualityDashboard.pdf index acac2a73..e35750d9 100644 Binary files a/inst/doc/DataQualityDashboard.pdf and b/inst/doc/DataQualityDashboard.pdf differ diff --git a/inst/doc/DqdForCohorts.pdf b/inst/doc/DqdForCohorts.pdf index 19b7ecaf..306e46d5 100644 Binary files a/inst/doc/DqdForCohorts.pdf and b/inst/doc/DqdForCohorts.pdf differ diff --git a/inst/doc/Thresholds.pdf b/inst/doc/Thresholds.pdf index 77627c27..0aa1e7f2 100644 Binary files a/inst/doc/Thresholds.pdf and b/inst/doc/Thresholds.pdf differ diff --git a/inst/sql/sql_server/field_cdm_datatype.sql b/inst/sql/sql_server/field_cdm_datatype.sql index 2635bf58..65dc22a4 100755 --- a/inst/sql/sql_server/field_cdm_datatype.sql +++ b/inst/sql/sql_server/field_cdm_datatype.sql @@ -30,11 +30,9 @@ FROM cdmTable.* FROM @cdmDatabaseSchema.@cdmTableName cdmTable WHERE - ISNUMERIC(cdmTable.@cdmFieldName) = 0 - OR ( - ISNUMERIC(cdmTable.@cdmFieldName) = 1 - AND CHARINDEX('.', CAST(ABS(cdmTable.@cdmFieldName) AS varchar)) != 0 - ) + (ISNUMERIC(cdmTable.@cdmFieldName) = 0 + OR (ISNUMERIC(cdmTable.@cdmFieldName) = 1 + AND CHARINDEX('.', CAST(ABS(cdmTable.@cdmFieldName) AS varchar)) != 0)) AND cdmTable.@cdmFieldName IS NOT NULL /*violatedRowsEnd*/ ) violated_rows