From 258a786617542b6f69522fdbe40a52ec683a6e06 Mon Sep 17 00:00:00 2001 From: Nathan Hall <106178605+nhall6@users.noreply.github.com> Date: Thu, 19 Sep 2024 13:42:36 -0400 Subject: [PATCH] Fixing #300 (#329) * Fixing #300 Syntax error in code was causing an issue in the rule sequencing, leading to incorrect attrition values. thanks to @chrisknoll for all the help * fixing R check fixing R check and removing a pointless file --------- Co-authored-by: jreps --- R/cohort-generator-main.R | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/R/cohort-generator-main.R b/R/cohort-generator-main.R index ee7fb97..71bfcd4 100644 --- a/R/cohort-generator-main.R +++ b/R/cohort-generator-main.R @@ -927,7 +927,7 @@ getCohortGenerationAttritionTable <- function( cohortRules <- rules %>% dplyr::filter(.data$cohortDefinitionId==cohortId) %>% dplyr::select("ruleSequence", "ruleName", "cohortName") %>% - dplyr::arrange("ruleSequence") + dplyr::arrange(.data$ruleSequence) testMask = 0 @@ -967,6 +967,7 @@ getCohortGenerationAttritionTable <- function( } attritionTableDistinct <- dplyr::distinct(attritionTable) + #adding drop counts attritionTableFinal <- attritionTableDistinct %>%