-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Saving a new Research Article Update as Draft triggers the webhook #3740
Comments
When you fix this, it would be good to add a corresponding unit test, you can use this as a base: https://github.com/ONEARMY/community-platform/blob/master/functions/src/Integrations/firebase-discord.test.ts |
@benfurber Good catch, I have updated the description. Someone please consider adding the label Good First Issue. :) |
Hello @onim-at, thanks for trying to take a look. It is slightly hard to answer your question, because it is not 100% clear which commands you used. But to answer your question. You should see it in the docker-compose terminal (the one you have labeled "Backend cmd") Here is a video, where I re-create the bug, showing the webhook is triggered, using the latest master code and exactly what commands to run and what to do in the user interface: The documentation on the onearmy website is out-of-date (unfortunately) so best to look directly at the markdown documentation: |
If anything is still unclear, please let me know. I realize now that the screen recording doesn't include mouse movements, which probably makes it even harder to understand. |
Thanks for picking this up @onim-at! Good luck. |
Hello @pizzaisdavid, thanks for the video explanation! I've synched my fork to the latest master branch commit and run the following commands
However the backend raises several error, some of which are On a more positive note, I've created a PR that should fix the issue but I couldn't test it due to the mentioned errors |
About the error, off the top of my head, I'm not sure. Which is annoying, because the Docker/backend emulator is supposed to be something nice that works for everyone. I have looked at your pr though. |
🎉 This issue has been resolved in version 1.212.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
To Reproduce
Steps to reproduce the behaviour:
Link to emulator: https://github.com/ONEARMY/community-platform/blob/master/packages/documentation/docs/Backend%20Development/firebase-emulator.md#commands
Expected behaviour
The webhook should not be triggered.
Also, as Ben has pointed out in the comments, that if the article is a draft, it is currently also possible to trigger the webhook, which is bad mm'kay.
The text was updated successfully, but these errors were encountered: