Downloads

[rmccar]

Use this place to discuss Downloads in the ONS Design System

[trevorsaint]

An improvement for this component would be to:

Add tabindex="-1" for the image thumbnail link.

We have an aria-hidden="true" attribute, which is great because we don’t want screen readers reading out the link twice.

However a keyboard user would still have to tab twice for the thumbnail link and the heading link.

They do the same thing. Adding tabindex="-1" will resolve this.

[rmccar]

An improvement for this component would be to:

Add tabindex="-1" for the image thumbnail link.

We have an aria-hidden="true" attribute, which is great because we don’t want screen readers reading out the link twice.

However a keyboard user would still have to tab twice for the thumbnail link and the heading link.

They do the same thing. Adding tabindex="-1" will resolve this.

Sounds good Ive raised a PR to fix this

[trevorsaint]

We need to update the thumbnail path to allow for a smallPath and a largePath.

Currently the macro expects a small and large folder (hardcoded into macro). However, with the way Craft does image modifications it names the folders with an underscore.

Allowing for a smallPath and a largePath would sort this issue out and also make the component more flexible.

[trevorsaint]

We need the ability to have a fallback image if no image specified as part of the component.

[trevorsaint]

I have spotted a bug with this component when used inside page__body. The margin is inherited causing incorrect margins.

See example:

The top image is how it should look. The bottom image is how it currently looks.

It might be worth adding a title class for the heading to control how it should be rendered.

[jrbarnes9]

Download thumbnail images shouldn't require alt text, as they are decorative