Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ons-js-toc-container class name to align with other class naming standard #3430

Open
rmccar opened this issue Nov 19, 2024 · 1 comment
Labels
Breaking changes This PR contains at least one breaking change Tech improvements Tech debt, cleanup, code standardisation etc.

Comments

@rmccar
Copy link
Contributor

rmccar commented Nov 19, 2024

In the PR #3424 we have updated the table of contents files to remove the toc acronym and move the names of files and classes inline with the other components. There was one class that we could not rename though without creating a breaking change. This was the ons-js-toc-container class, this is because we have documentation that instructs users to set this class on a div to contain the table of contents in some instances (https://service-manual.ons.gov.uk/design-system/components/table-of-contents#example.example-table-of-contents-sticky.nunjucks). Because of this, this is a breaking change and as it doesn't need to be made now we should wait to make it when we are doing our next major release.

@rmccar rmccar added Breaking changes This PR contains at least one breaking change Tech improvements Tech debt, cleanup, code standardisation etc. labels Nov 19, 2024
@MagdalenaLarge
Copy link

Moved to Jira: https://jira.ons.gov.uk/browse/ONSDESYS-203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking changes This PR contains at least one breaking change Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Development

No branches or pull requests

2 participants