Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE 1 day] Autosuggest #220

Open
MagdalenaLarge opened this issue Sep 23, 2024 · 1 comment
Open

[SPIKE 1 day] Autosuggest #220

MagdalenaLarge opened this issue Sep 23, 2024 · 1 comment
Assignees
Labels
Medium Priority Spike Tech improvements Tech debt, cleanup, code standardisation etc.

Comments

@MagdalenaLarge
Copy link

Description

There is a ariaResultsLabel in Autosuggest component that is set in some tests but doesn't seem to be actually used to do anything. This needs investigating and removing if that is the case.

@MagdalenaLarge MagdalenaLarge added Spike Medium Priority Tech improvements Tech debt, cleanup, code standardisation etc. labels Sep 23, 2024
@SriHV SriHV self-assigned this Nov 6, 2024
@SriHV
Copy link

SriHV commented Nov 8, 2024

ariaResultsLabel was added as part of DAC review which said to add an additional aria-label in autosuggest component,see this PR

This was later replaced with aria-labelledby which used label and id due to breaking changes, see this PR

This parameter was subsequently removed from documentation, see this PR.

Since it was replaced with other parameters, we can remove ariaResultsLabel from the remaining locations as well.

We can create a new ticket to remove this parameter entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium Priority Spike Tech improvements Tech debt, cleanup, code standardisation etc.
Projects
None yet
Development

No branches or pull requests

2 participants