Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Ratio of Means take question_no as input? #81

Open
Jday7879 opened this issue Aug 29, 2024 · 3 comments
Open

Should Ratio of Means take question_no as input? #81

Jday7879 opened this issue Aug 29, 2024 · 3 comments
Labels
question Further information is requested

Comments

@Jday7879
Copy link
Collaborator

Should the ratio of means funcntion take question number as an input.
Currently to produce outputs we need to groupby question_no in order to run for each question.
We can either filter results before running the function to only run on specific questions or provice this as an input for functions down the line.

Join manual constructions might need to be updated to take question_no as input to correctly join values.

@Jday7879 Jday7879 added the question Further information is requested label Aug 29, 2024
@sarahcollyer
Copy link
Collaborator

Think we can just add question as an option in the config. Where does the groupby need to happen? As we might need to edit the function to add that. And are there any other functions we need to check/edit?

@Jday7879
Copy link
Collaborator Author

I think the only function which will need to be updated will be the join_manual_constructions on the main branch as this has question_no set as a default argument as a temporary work around.

The groupby runs as a Lambda function on the testing_outputs branch L39 in testing_main.py, It will probably need another pull request to make any changes to the testing outputs as these are not in the main package.

@Jday7879
Copy link
Collaborator Author

Jday7879 commented Oct 3, 2024

@sarahcollyer @shilohd Sorry I replied to this before but forgot to tag you both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants