Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Latest commit

 

History

History
31 lines (23 loc) · 1.64 KB

IMPROVEMENTS.md

File metadata and controls

31 lines (23 loc) · 1.64 KB
Raw

Service Improvements

The action exporter could easily be simplified and bought up to date.

  1. Remove the use of XML/XSD and replace with JSON
  2. Remove the Rest API endpoints for adding, updating and querying templates. These are not used in production and if we require an additional template it would be easy enough to add directly to the database or...
  3. potentially embed the templates inside the code where it can be version control and reviewed.
  4. Add rest endpoints for retrigger the action exporter or create a mechanism to retry failed exports
  5. The generated file should be persisted somewhere before it is sent to the SFTP server.
  6. Remove the export report (filerowcount) table, it's not used and repeats information in the export file table. The row count could be stored there if its needed.
  7. Remove the export job table, it's unnecessary.
  8. Only one template is ever used but we have mechanism for using multiple and dynamically storing others. Is this actually needed?
  9. Remove the message log table since the removal of the store procedures this hasn't been used since 2018.
  10. Investigate removing the contact and address tables, they are hardly used and when this is actually needed it could be looked up via the party service.

Rewrite

This service lends itself nicely to a rewrite as it is isolated being an outer service and has a single distinct job and would massively benefit from simplification

The potential options would be:

  1. Go using Go templates
  2. Python using jninja templating

The other option is to upgrade this service to Spring Boot 2, move the freemarker templates into and simplify the follow as much as possible.