From e40faa59fb8f659c97461ed15d165edd18d985c8 Mon Sep 17 00:00:00 2001 From: x256 <153709773+xTwo56@users.noreply.github.com> Date: Sat, 30 Mar 2024 14:42:15 +0530 Subject: [PATCH 1/3] feat: modified struct Details and addPerson function --- contract/Database.sol | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/contract/Database.sol b/contract/Database.sol index 99899cb..cffe428 100644 --- a/contract/Database.sol +++ b/contract/Database.sol @@ -2,11 +2,14 @@ pragma solidity >=0.7.0<0.9.0; contract Database{ + struct Details { string aadharId; string name; string DOB; string phoneNo; + uint rollNo; + uint batchNo; } @@ -18,9 +21,9 @@ contract Database{ } - function addPerson(string calldata aadharId,string calldata name, string calldata DOB, string calldata phoneNo) public + function addPerson(string calldata aadharId,string calldata name, string calldata DOB, string calldata phoneNo, uint rollNo, uint batchNo) public { - Details memory person = Details({aadharId: aadharId,name: name,DOB: DOB,phoneNo: phoneNo}); + Details memory person = Details({aadharId: aadharId,name: name,DOB: DOB,phoneNo: phoneNo, rollNo: rollNo, batchNo: batchNo}); list[count]=person; count++; } From 9e90b806b7ef67dfa4a9dc0495f9802aad9c92d7 Mon Sep 17 00:00:00 2001 From: xTwo56 <153709773+xTwo56@users.noreply.github.com> Date: Sat, 30 Mar 2024 15:50:43 +0530 Subject: [PATCH 2/3] fix: changed storage location of details in addperson --- contract/Database.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contract/Database.sol b/contract/Database.sol index cffe428..860b533 100644 --- a/contract/Database.sol +++ b/contract/Database.sol @@ -23,7 +23,7 @@ contract Database{ function addPerson(string calldata aadharId,string calldata name, string calldata DOB, string calldata phoneNo, uint rollNo, uint batchNo) public { - Details memory person = Details({aadharId: aadharId,name: name,DOB: DOB,phoneNo: phoneNo, rollNo: rollNo, batchNo: batchNo}); + Details storage person = Details({aadharId: aadharId,name: name,DOB: DOB,phoneNo: phoneNo, rollNo: rollNo, batchNo: batchNo}); list[count]=person; count++; } From 80390848c44f2d91f2036539e063ab3d8459bca0 Mon Sep 17 00:00:00 2001 From: xTwo56 <153709773+xTwo56@users.noreply.github.com> Date: Sat, 30 Mar 2024 20:09:18 +0530 Subject: [PATCH 3/3] feat: changed rollno, batchno to string --- contract/Database.sol | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contract/Database.sol b/contract/Database.sol index 860b533..ba7c246 100644 --- a/contract/Database.sol +++ b/contract/Database.sol @@ -8,8 +8,8 @@ contract Database{ string name; string DOB; string phoneNo; - uint rollNo; - uint batchNo; + string rollNo; + string batchNo; } @@ -21,9 +21,9 @@ contract Database{ } - function addPerson(string calldata aadharId,string calldata name, string calldata DOB, string calldata phoneNo, uint rollNo, uint batchNo) public + function addPerson(string memory aadharId,string memory name, string memory DOB, string memory phoneNo, string memory rollNo, string memory batchNo) public { - Details storage person = Details({aadharId: aadharId,name: name,DOB: DOB,phoneNo: phoneNo, rollNo: rollNo, batchNo: batchNo}); + Details memory person = Details({aadharId: aadharId,name: name,DOB: DOB,phoneNo: phoneNo, rollNo: rollNo, batchNo: batchNo}); list[count]=person; count++; }