From 64e1639b2f0dcbfa64bba4d1f0d5972832843625 Mon Sep 17 00:00:00 2001
From: Daniel Palafox <dp852@hotmail.com>
Date: Wed, 13 Mar 2024 08:26:22 -0600
Subject: [PATCH] fix: Add missing arialabel (#2191)

Co-authored-by: Daniel Palafox <daniel.p4l4fox@gmail.com>
Co-authored-by: Angel Montenegro <a.montenegro@orcid.org>
---
 .../cdk/info-drop-down/info-drop-down.component.html  | 11 +++++++++--
 .../cdk/info-drop-down/info-drop-down.component.ts    |  6 ++++++
 src/locale/properties/shared/shared.en.properties     |  2 ++
 src/locale/properties/shared/shared.lr.properties     |  2 ++
 src/locale/properties/shared/shared.rl.properties     |  2 ++
 src/locale/properties/shared/shared.xx.properties     |  2 ++
 6 files changed, 23 insertions(+), 2 deletions(-)

diff --git a/src/app/cdk/info-drop-down/info-drop-down.component.html b/src/app/cdk/info-drop-down/info-drop-down.component.html
index b3af03ce52..40f2dea5af 100644
--- a/src/app/cdk/info-drop-down/info-drop-down.component.html
+++ b/src/app/cdk/info-drop-down/info-drop-down.component.html
@@ -17,10 +17,17 @@
 
 <ng-container *ngIf="signInUpdatesV1Togglz">
   <div class="row">
-    <b class="orc-font-body m-b-16">
+    <b class="orc-font-body m-b-8">
       {{ name }}
     </b>
-    <a class="underline" [ngClass]="{ 'm-b-16': show }" (click)="show = !show">
+  </div>
+  <div class="row">
+    <a
+      class="underline"
+      [ngClass]="{ 'm-b-16': show }"
+      (click)="show = !show"
+      [attr.aria-label]="(!show ? ariaLabelShowDetailsFor : ariaLabelHideDetailsFor) + ' ' + name "
+    >
       <ng-container i18n="@@shared.showDetails" *ngIf="!show"
         >Show details</ng-container
       >
diff --git a/src/app/cdk/info-drop-down/info-drop-down.component.ts b/src/app/cdk/info-drop-down/info-drop-down.component.ts
index df61707120..60cd598db4 100644
--- a/src/app/cdk/info-drop-down/info-drop-down.component.ts
+++ b/src/app/cdk/info-drop-down/info-drop-down.component.ts
@@ -13,6 +13,12 @@ export class InfoDropDownComponent implements OnInit {
   @Input() description
   @Input() signInUpdatesV1Togglz: boolean
   show = false
+
+  ariaLabelShowDetailsFor = $localize`:@@shared.showDetailsFor:Show details for`
+  ariaLabelHideDetailsFor = $localize`:@@shared.hideDetailsFor:Hide details for`
+
+
+
   constructor() {}
 
   ngOnInit(): void {}
diff --git a/src/locale/properties/shared/shared.en.properties b/src/locale/properties/shared/shared.en.properties
index 7d5e47b421..56863e08e0 100644
--- a/src/locale/properties/shared/shared.en.properties
+++ b/src/locale/properties/shared/shared.en.properties
@@ -633,3 +633,5 @@ shared.educationSortSource=Sort education and qualifications by source
 shared.fundingSortSource=Sort funding by source
 shared.professionalActivitiesSortSource=Sort professional activities by source
 shared.worksSortSource=Sort works by source
+shared.showDetailsFor=Show details for
+shared.hideDetailsFor=Hide details for
diff --git a/src/locale/properties/shared/shared.lr.properties b/src/locale/properties/shared/shared.lr.properties
index f6e5018dde..e80edd1c2e 100644
--- a/src/locale/properties/shared/shared.lr.properties
+++ b/src/locale/properties/shared/shared.lr.properties
@@ -656,3 +656,5 @@ shared.educationSortSource=LR
 shared.fundingSortSource=LR
 shared.professionalActivitiesSortSource=LR
 shared.worksSortSource=LR
+shared.showDetailsFor=LR
+shared.hideDetailsFor=LR
diff --git a/src/locale/properties/shared/shared.rl.properties b/src/locale/properties/shared/shared.rl.properties
index f9482533f0..786cf81681 100644
--- a/src/locale/properties/shared/shared.rl.properties
+++ b/src/locale/properties/shared/shared.rl.properties
@@ -652,3 +652,5 @@ shared.educationSortSource=RL
 shared.fundingSortSource=RL
 shared.professionalActivitiesSortSource=RL
 shared.worksSortSource=RL
+shared.showDetailsFor=RL
+shared.hideDetailsFor=RL
diff --git a/src/locale/properties/shared/shared.xx.properties b/src/locale/properties/shared/shared.xx.properties
index 566af2eb6e..8d94d35da4 100644
--- a/src/locale/properties/shared/shared.xx.properties
+++ b/src/locale/properties/shared/shared.xx.properties
@@ -652,3 +652,5 @@ shared.educationSortSource=X
 shared.fundingSortSource=X
 shared.professionalActivitiesSortSource=X
 shared.worksSortSource=X
+shared.showDetailsFor=X
+shared.hideDetailsFor=X