Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activities: Section header links & buttons #1093

Open
dandineen opened this issue Sep 10, 2021 · 1 comment
Open

Activities: Section header links & buttons #1093

dandineen opened this issue Sep 10, 2021 · 1 comment

Comments

@dandineen
Copy link
Contributor

dandineen commented Sep 10, 2021

Add in clear hover, active and focus states. The Material defaults aren't very easy to see.

Screenshot 2021-09-10 at 15 41 36

In this screengrab the 'Add' button is actually active but you can't really see it!

The basic hover styling is defined in Figma: https://www.figma.com/file/LN4ZEEGC8E1JeZZwDHSOGO/Activities-https-trello.com-c-qiUa5KP1?node-id=87%3A287

Product/UX will specify styling for focus and active states.

Make sure both the icon and the label are active and clickable on all section headers. I've only spotted this issue on the Employment (+) Add button but it might be present on other headers.

@dandineen
Copy link
Contributor Author

I've updated the Activities Figma file with a full set of styles for the section headers.

https://www.figma.com/file/LN4ZEEGC8E1JeZZwDHSOGO/Activities-https-trello.com-c-qiUa5KP1?node-id=87%3A287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant