Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modals: The modal border is missing #1096

Open
dandineen opened this issue Sep 10, 2021 · 0 comments
Open

Modals: The modal border is missing #1096

dandineen opened this issue Sep 10, 2021 · 0 comments
Assignees
@DanielPalafox

Comments

@dandineen
Copy link
Contributor

The modals should have a 2px $ui-background-darkest (#212121) border around them.

I think it should be applied to <mat-dialog-container>.
@DanielPalafox DanielPalafox self-assigned this Sep 15, 2021
DanielPalafox added a commit that referenced this issue Sep 15, 2021
@DanielPalafox
fix: modal border
ac357af 
see the issue for details

fixes issue #1096
@DanielPalafox DanielPalafox mentioned this issue Sep 15, 2021
Merged
amontenegro pushed a commit that referenced this issue Sep 15, 2021
@DanielPalafox
fix: modal border (#1135)
1611f4e 
see the issue for details

fixes issue #1096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielPalafox DanielPalafox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dandineen @DanielPalafox