Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midterm Peer Review #72

Open
mnercessian opened this issue Nov 18, 2020 · 0 comments
Open

Midterm Peer Review #72

mnercessian opened this issue Nov 18, 2020 · 0 comments

Comments

@mnercessian
Copy link

This project aims to elucidate the difference in performance of NBA players in contract years vs non-contract years. Additionally, they seek to create a quantification of the "contract year effect" for each player using what they call a "slippery index." They have season statistics for 100 players over 989 total seasons at their disposal to accomplish this goal.

Things I liked

  • The justification for leaving out certain features on the basis of the correlation matrix and information embedded in other features was very nicely done.
  • The realization that you could be introducing age bias by just comparing contract vs non-contract years was smart, and I like the way you overcame the issue by only comparing non-consecutive contract year vs post-contract year.
  • I liked all the visualizations of the data. They did a great job of exploring the dataset and drew solid conclusions from it.

Areas for improvement

  • Many of the statistical differences are very small. It would be nice if you only highlighted values that were significantly different because it's hard to understand the differences the way it is presented. I see this will be in your future work which is good.
  • I would have liked a more in-depth explanation of what the slippery index is, and how you will attempt to construct it.
  • It would be nice to have a discussion on over/underfitting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant