Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with Netcat as a requirement #7

Open
wattry opened this issue Mar 5, 2019 · 3 comments
Open

Update README.md with Netcat as a requirement #7

wattry opened this issue Mar 5, 2019 · 3 comments

Comments

@wattry
Copy link

wattry commented Mar 5, 2019

The script that is generated by the example uses Netcat , this will cause failures.

The rstudio docs have contain nc as a prerequisite.

@ericfranz
Copy link
Contributor

Would it be preferable for us to modify the code to not use netcat, or try netstat if netcat is not available i.e. your suggestion:

port_used () {
  local port="{1#*:}" sleep 2 netstat -nap 2>/dev/null | grep -q "0.0.0.0:{port} "
}

@wattry
Copy link
Author

wattry commented Mar 5, 2019

Well, that would preferable for us, our ops team won't permit applications that may make our systems more vulnerable.

It's really your call, I just figured it would be easier for you to update the README then to update the script. It took a few hours to debug this because no error is output when the nc call fails.

@MorganRodgers
Copy link

I agree that if there are problems with asking sites to install netcat then we should do something else.

But, as for the correct fix for this issue, netcat is listed as a dependency in the setting up interactive apps section of the OnDemand documentation for version 1.5 / master. Example interactive apps need to link to that documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants