Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve tag transition #5

Open
kaivalyar opened this issue Dec 22, 2016 · 3 comments
Open

improve tag transition #5

kaivalyar opened this issue Dec 22, 2016 · 3 comments
Labels

Comments

@kaivalyar
Copy link
Member

the tags below each project in the the projects page all actually function as links - to nothing.

the elements can be done away with (deleted/replaced with span). I would've done this myself, but I'm not sure if it'll have any other repercussions.

@kaivalyar
Copy link
Member Author

I have converted anchors to span, and committed to master. Somebody please review and close this issue.

@SebastinSanty
Copy link
Member

I guess there is a minor problem during the highlight on hover. The rectangle part gets highlighted before the arrow part. Though I am not sure of it, I think span is the culprit. Can you test this locally. Or else I have put them as anchor tags here, if you want to check.

As for the linking part, I guess removing href and replacing it with name attribute would work.

@kaivalyar
Copy link
Member Author

Ok i figured it out - it's because i changed the transition css property from color to background. apparently, the background transition applies to the element, but not to its padding - an error in the browser, certainly, which will hopefully be fixed in a few years. Until then, can somebody ... figure out what to change the transition to?

@kaivalyar kaivalyar changed the title remove defunct project links improve tag transition Jan 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants