-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] testsuite: do not run tests for deprecated module #975
Comments
I guess that things happen here: grass-addons/.github/workflows/ci.yml Line 91 in 82d59ce
which calls Here it appears that grass-addons/src/raster/Makefile Line 5 in 82d59ce
but apparently that mechanism isn't used? |
It seems to me, that r.in.pdal is not compiled, so the When the unittest is started here: https://github.com/OSGeo/grass-addons/blob/82d59ce1424be8d7fac485836b3af5c00bba3b33/.github/workflows/test.sh#L15C16-L15C34 |
Before adding more code to grass.gunittest, I suggest:
|
Agreed. So:
I suggest to remove all of them. Git preserves the history anyway. |
testsuite for addons
For example, the r.in.pdal module is deprecated in addons: https://github.com/OSGeo/grass-addons/blob/grass8/src/raster/r.in.pdal/DEPRECATED
However, the testsuite for that module runs never the less and of course fails, e.g.:
https://github.com/OSGeo/grass-addons/actions/runs/6706180778/job/18222154754#step:17:303
No testsuite should run for deprecated modules...
Not sure how to create that exception in the testsuite, or if the test map simply should be renamed so that tests are not picked up...
The text was updated successfully, but these errors were encountered: