Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Generic Dask-Image Filter to Clean Subpackage and Potential Rename of Subpackage #1327

Open
ctuguinay opened this issue Jun 4, 2024 · 0 comments
Assignees
Labels
data format Anything about data format enhancement This makes echopype better feature request
Milestone

Comments

@ctuguinay
Copy link
Collaborator

From discussion w/ Wu-Jung on #1326:

Having a wrapper around Dask-Image's generic_filter would be a pretty good thing to have in Echopype, and it will already be used in the binning implementation of echopype.clean.mask_transient_noise. Having it with all the other image masking functions (noise and attenuation masking) would not fit the Clean subpackage name, since the filter being applied doesn't necessarily need to be used for 'cleaning', since it can be used to extract temporal-spatial information about the echogram. One possible rename option would be Filter, but there are other filtering operations that occur in echosounder data processing that isn't necessarily on the Echogram level. One such example is the match filtering that happens in calibrating Sv.

@ctuguinay ctuguinay added enhancement This makes echopype better feature request data format Anything about data format labels Jun 4, 2024
@ctuguinay ctuguinay added this to the v0.9.0 milestone Jun 4, 2024
@ctuguinay ctuguinay self-assigned this Jun 4, 2024
@github-project-automation github-project-automation bot moved this to Todo in Echopype Jun 4, 2024
@ctuguinay ctuguinay modified the milestones: v0.9.0, v0.9.1 Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data format Anything about data format enhancement This makes echopype better feature request
Projects
Status: Todo
Development

No branches or pull requests

1 participant