Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fielding transient noise mask #1352

Open
leewujung opened this issue Jul 4, 2024 · 1 comment
Open

Add Fielding transient noise mask #1352

leewujung opened this issue Jul 4, 2024 · 1 comment

Comments

@leewujung
Copy link
Member

leewujung commented Jul 4, 2024

The transient noise (TN) filter from Ryan et al. 2015 is slow due to the need to sort in calculating median for each window surrounding a given pixel.

Alejandro Ariza (@alejandro-ariza) and Sophie Fielding in British Antarctic Survey (BAS) has figured a new approach that works pretty well. It is implemented in echopy here and documented in the docstrings. It would be good to add this functionality.

The masking results look like:

@ctuguinay
Copy link
Collaborator

ctuguinay commented Jul 4, 2024

Ryan's implementation entails iterating through each ping time and each depth value, whereas Fielding's implementation entails iterating through each ping time and some of the depth values until a certain noise threshold condition is met. In this sense, Ryan's is ~O(n^2) whereas Fielding's approach is ~O(n * log(n) ).

@leewujung leewujung added the AA SI label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants