Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply_mask should only take in boolean masks #1377

Open
ctuguinay opened this issue Aug 22, 2024 · 0 comments
Open

apply_mask should only take in boolean masks #1377

ctuguinay opened this issue Aug 22, 2024 · 0 comments
Labels
enhancement This makes echopype better feature request
Milestone

Comments

@ctuguinay
Copy link
Collaborator

After talking to @leewujung, we should modify apply_mask to enforce that the masks passed in are boolean masks.

Users can currently pass in masks that are 1/0 and 1/NaN, which stand for True/False; however, more obscure configurations can be passed in, such as arbitrary float/NaN, with the current way that apply_mask handles and applies masks onto Sv/MVBS data, and this makes it a bit confusing for what the user should pass in.

@ctuguinay ctuguinay added this to the v0.9.1 milestone Aug 22, 2024
@github-project-automation github-project-automation bot moved this to Todo in Echopype Aug 22, 2024
@ctuguinay ctuguinay added enhancement This makes echopype better feature request labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This makes echopype better feature request
Projects
Status: Todo
Development

No branches or pull requests

1 participant