Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Memory Expansion of regions2d.mask #141

Open
ctuguinay opened this issue Sep 29, 2023 · 0 comments
Open

Investigate Memory Expansion of regions2d.mask #141

ctuguinay opened this issue Sep 29, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ctuguinay
Copy link
Collaborator

ctuguinay commented Sep 29, 2023

The regions2d.mask function is a wrapper function around regionmask's mask_3D function. Originally, the function was a wrapper around regionmask's mask function which is a 2D mask creation function, so the current concern is the memory expansion that will result when there are many masks being computed in the current iteration of regions2d.mask.

Currently, I'm not too sure if regionmask .mask function uses mask_3D under the hood since the documentation is hard to read, but the 2d and 3d masking functions in that repository use the same underlying mask function.

In the near-future, if we do end up encountering memory issues, we can just iterate and use very few region_id values as input to the mask function.

@leewujung describes the problem here too: #139 (review)

@ctuguinay ctuguinay added the bug Something isn't working label Sep 29, 2023
@ctuguinay ctuguinay added this to the v0.2.0 milestone Sep 29, 2023
@leewujung leewujung removed this from the v0.2.0 milestone Dec 11, 2023
@ctuguinay ctuguinay self-assigned this Apr 26, 2024
@ctuguinay ctuguinay moved this to Todo in Echoregions Apr 26, 2024
@ctuguinay ctuguinay added this to the v0.3.0 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants