Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show the PRs that a user has reviewed on their profile - similar to the show PRs on user profile #3283

Open
DonnieBLT opened this issue Jan 27, 2025 · 19 comments · May be fixed by #3302
Open

Comments

@DonnieBLT
Copy link
Collaborator

No description provided.

@tsu-ki
Copy link
Contributor

tsu-ki commented Jan 28, 2025

/assign

Copy link
Contributor

Hello @tsu-ki! You've been assigned to OWASP-BLT/BLT issue #3283. You have 24 hours to complete a pull request.

@tsu-ki
Copy link
Contributor

tsu-ki commented Jan 28, 2025

@DonnieBLT sir, how would we determine if a user has made reviews on a PR?

@DonnieBLT
Copy link
Collaborator Author

from the requested_reviewers field

@tsu-ki
Copy link
Contributor

tsu-ki commented Jan 28, 2025

from the requested_reviewers field

understood, thank you

@iitzIrFan
Copy link

@tsu-ki Actually you will need an model to get the required data which I and @DonnieBLT were working on and were waiting for the model pr to be reviewed and to be merged in main branch !

@tsu-ki
Copy link
Contributor

tsu-ki commented Jan 29, 2025

@tsu-ki Actually you will need an model to get the required data which I and @DonnieBLT were working on and were waiting for the model pr to be reviewed and to be merged in main branch !

another model isn't necessarily required. In the get_context_data method of UserProfileDetailView, after getting the user's github url, I'm extracting their GitHub username from the github_url. Then, using the GitHub API to fetch the reviewed PRs.

@iitzIrFan
Copy link

@tsu-ki Nice approach actually Donnie mentioned the models pr as an reference so got this approach at that, time

@DonnieBLT
Copy link
Collaborator Author

We will also want to have the model to do the leaderboard

@tsu-ki
Copy link
Contributor

tsu-ki commented Jan 29, 2025

We will also want to have the model to do the leaderboard

sir, so we have to store the reviewer information in DB?

@DonnieBLT
Copy link
Collaborator Author

Yes, for reviewers and contributors

@iitzIrFan
Copy link

@DonnieBLT This is there in the model pr I guess?

@DonnieBLT
Copy link
Collaborator Author

Yes https://github.com/OWASP-BLT/BLT/pull/3266/files

@iitzIrFan
Copy link

@DonnieBLT It's still in review process so @tsu-ki need to wait for some time also I want some issues to work on @DonnieBLT can you help me out!

@tsu-ki
Copy link
Contributor

tsu-ki commented Jan 29, 2025

Yes https://github.com/OWASP-BLT/BLT/pull/3266/files

@DonnieBLT sir, should I wait for the corresponding PR to be merged?

@DonnieBLT
Copy link
Collaborator Author

You could copy the code and add it here. I’ll make sure to merge both branches so you both get credit.

@tsu-ki
Copy link
Contributor

tsu-ki commented Jan 29, 2025

You could copy the code and add it here. I’ll make sure to merge both branches so you both get credit.

sure, I'll rebase my branch and work on the new model created by @SahilDhillon21

@SahilDhillon21
Copy link
Contributor

Apologies for the delay, I'll push the code by tomorrow

Copy link
Contributor

⏰ This issue has been automatically unassigned due to 24 hours of inactivity.
The issue is now available for anyone to work on again.

@tsu-ki tsu-ki linked a pull request Jan 30, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

4 participants