Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rel attributes are reordered in 20220608.1 #336

Open
damianszczepanik opened this issue Apr 13, 2024 · 0 comments
Open

rel attributes are reordered in 20220608.1 #336

damianszczepanik opened this issue Apr 13, 2024 · 0 comments

Comments

@damianszczepanik
Copy link

Upgrading to version 20240325.1 (previous 20220608.1 works fine) makes my testing failing because order of REL values changes. What is worse when I fix the order it passes with JDK17 but fails with JDK11

Test that starts failing
https://github.com/damianszczepanik/cucumber-reporting/blob/8aed0cc6e6c41413b87047d0b89f73d750d37206/src/test/java/net/masterthought/cucumber/generators/EscapeHtmlReferenceTest.java#L66

Error message for JDK11

expected: "<a href="www.example.com" rel="nofollow noreferrer noopener">a hyper web reference</a>"
 but was: "<a href="www.example.com" rel="nofollow noopener noreferrer">a hyper web reference</a>"

PR with build/test output damianszczepanik/cucumber-reporting#1179

Basically having this implementation is hardly possible to maintain code that is tested against different JVMs

draperunner added a commit to digipost/digipost-html-validator that referenced this issue Apr 15, 2024
This upgrades the OWASP sanitizer library to the latest version. Guava
is removed from this version.
https://github.com/OWASP/java-html-sanitizer/releases/tag/release-20220608.1

The order of noreferrer, nofollow, noopener is apparently random now, so
I had to rewrite those tests to not care about order
(OWASP/java-html-sanitizer#336).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant