Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace tfsec with trivy on github workflows and renovate.json #1801

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Replace tfsec with trivy on github workflows and renovate.json #1801

wants to merge 5 commits into from

Conversation

za
Copy link
Contributor

@za za commented Dec 16, 2024 •
edited by commjoen
Loading

Issue: #1764

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

Update to trivy because tfsec is no longer updated

Relations

Closes #1764

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@commjoen
Copy link
Collaborator

Good morning @za ! Good to see you back here. It seems there are some errors: can you please check https://github.com/OWASP/wrongsecrets/actions/runs/12352280456/job/34468977401?pr=1801 ?

@za
Copy link
Contributor Author

za commented Dec 16, 2024

Hi @commjoen it's almost midnight here ;) How do I set TRIVY_VERSION hence I am not the maintainer of this repo?

@za
Copy link
Contributor Author

za commented Dec 17, 2024

Hi @commjoen it's almost midnight here ;) How do I set TRIVY_VERSION hence I am not the maintainer of this repo?

Wait, now I see TRIVY_VERSION in the pre-commit.yml file @commjoen I'm making the changes now...

@za
Copy link
Contributor Author

za commented Dec 17, 2024

Hi @commjoen now all checks have passed 🎉 Can you review the PR?

@commjoen
Copy link
Collaborator

Thank you for your PR sir! Hope to have a look next week,

@za
Copy link
Contributor Author

za commented Dec 17, 2024

Thank you for your PR sir! Hope to have a look next week,

Thanks sir @commjoen !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commjoen commjoen Awaiting requested review from commjoen commjoen is a code owner

@bendehaan bendehaan Awaiting requested review from bendehaan bendehaan is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate tfsec to trivy
2 participants
@za @commjoen