OXDEV-8213: Remove filter and return check for authorization test

OXID-eSales · Jun 28, 2024 · d34a036 · d34a036
1 parent d992d30
commit d34a036
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 23 deletions.
diff --git a/src/Theme/Infrastructure/ThemeListInfrastructureInterface.php b/src/Theme/Infrastructure/ThemeListInfrastructureInterface.php
@@ -14,7 +14,7 @@ interface ThemeListInfrastructureInterface
 {
     /**
      * @return array<ThemeDataType>
-     *@throws ThemesNotFound
+     * @throws ThemesNotFound
      */
     public function getThemes(): array;
 }
diff --git a/tests/Codeception/Acceptance/BaseCest.php b/tests/Codeception/Acceptance/BaseCest.php
@@ -53,9 +53,4 @@ protected function getAdminPassword(): string
     {
         return self::ADMIN_PASSWORD;
     }
-
-    public function getThemeId(): string
-    {
-        return getenv('THEME_ID') ?: 'apex';
-    }
 }
diff --git a/tests/Codeception/Acceptance/Theme/ThemeListCest.php b/tests/Codeception/Acceptance/Theme/ThemeListCest.php
@@ -26,30 +26,15 @@ public function testThemeListAuthorized(AcceptanceTester $I): void
 
         $result = $this->runThemeListQuery($I);
         $I->assertArrayNotHasKey('errors', $result);
-
-        $themeList = $result['data']['themesList'];
-
-        foreach ($themeList as $theme) {
-            $I->assertSame($this->getThemeId(), $theme['identifier']);
-            $I->assertTrue($theme['active']);
-        }
     }
 
-    public function runThemeListQuery(AcceptanceTester $I): array
+    private function runThemeListQuery(AcceptanceTester $I): array
     {
         $I->login($this->getAdminUsername(), $this->getAdminPassword());
-        $themeId = $this->getThemeId();
         $I->sendGQLQuery(
             'query themeList {
 			  themesList(
-				filters: {
-				  active: {
-					equals: true
-				  }
-				  title: {
-				  	contains: "' . $themeId . '"
-				  }
-				}
+				filters: null
 			  ) {
 				title
 				identifier