Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Property, Cyber] BIWaitingPeriod change datatype from smallint to float #186

Open
3 tasks
johcarter opened this issue May 24, 2024 · 2 comments
Open
3 tasks
Assignees
Labels
minor minor release (non-breaking change)

Comments

@johcarter
Copy link
Contributor

Description

For Cyber policies, BI Waiting Period is normally expressed in hours, not days. Existing datatype is small int, meaning it only supports whole days not fractions of days (ie hours).

Reasons for change

To avoid adding a similar field BIWaitingPeriodHours for Cyber policies, change the datatype of BIWaitingPeriod from smallint to float. When waiting period is in hours it can be input into existing BIWaitingPeriod as a fraction of a day.

Scope of change

  • [ X] Location File
  • Accounts File
  • Reinsurance Scope
  • Reinsurance Info

Impact of change

non-breaking, minor

Data type, default values, are blanks allowed, list valid values

Field Name Data type Default values Blanks allowed Valid values
BIWaitingPeriod float 0 Yes [0,)
@johcarter johcarter added the minor minor release (non-breaking change) label May 24, 2024
@johcarter johcarter self-assigned this May 24, 2024
@johcarter
Copy link
Contributor Author

Valid value range change too

johcarter added a commit that referenced this issue Jun 26, 2024
@MattDonovan82
Copy link
Contributor

no further comments. Moving to done.

sambles pushed a commit that referenced this issue Jul 17, 2024
sambles pushed a commit that referenced this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor minor release (non-breaking change)
Projects
Status: Done
Status: Todo
Status: Agreed and ready
Development

No branches or pull requests

2 participants