Merged Develop to resolved conflicts with OEDv4, and update quoting #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* CI update for v4 OED release (#211) * test pr list build artifact * Fix unexpected column name change * Add build step to post excel on PR's * Add script to update rel links * Update release script for test * check * Fix * release test working * revert extractor changes * only test pushes on master/dev
Co-authored-by: Sam Gamble <[email protected]>
* use minimal quoting instead of all quoting to save csv file * update readme to reflect change from xlsx to csv * fix for OpenExposureData/AreaCodeValues.csv AreaCode leading 0
Merge branch 'release/3.4.1' of https://github.com/OasisLMF/ODS_OpenExposureData into release/3.4.1
Release 3.4.1
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
sambles
requested review from
johcarter and
MattDonovan82
and removed request for
MattDonovan82
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
sambles
changed the title
sambles
changed the title
sambles
force-pushed
the
fix-merge-conf_OEDv4
branch
from
30748a3 to
c7030a8
Compare
Build PreviewYou can find files attached to the below linked Workflow Run URL (Logs).
|
johcarter
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged Develop to resolved conflicts with OEDv4, and update quoting
Taken the
release/4.0.0branch and merged indevelop, then resolved any conflicts.All versions of the CSV under
OpenExposureData/*were taken 'as is' from therelease/4.0.0branch, and then had the double quoiting added to all CSV files.JSON Spec output for comparison
The two match except for some list reshuffling (which shouldn't matter)
This-PR__OpenExposureData_Spec.json
Release-OEDv4_OpenExposureData_Spec.json