Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lot3 - worker monitor compatibility fix needed #1052

Closed
sambles opened this issue May 23, 2024 · 0 comments · Fixed by #1054
Closed

Lot3 - worker monitor compatibility fix needed #1052

sambles opened this issue May 23, 2024 · 0 comments · Fixed by #1054
Assignees
Milestone

Comments

@sambles
Copy link
Contributor

sambles commented May 23, 2024

Issue Description

From #958

Traceback (most recent call last):
  File "/home/server/.local/lib/python3.10/site-packages/celery/app/trace.py", line 477, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/home/server/.local/lib/python3.10/site-packages/celery/app/trace.py", line 760, in __protected_call__
    return self.run(*args, **kwargs)
  File "/var/www/oasis/src/server/oasisapi/analyses/v2_api/tasks.py", line 556, in record_losses_files
    for name, put_location in result['raw_output_locations'].items():
KeyError: 'raw_output_locations'

Happens because worker-monitor is expecting every V2 worker to return raw_output_locations in its result, which is not true for older 2.3.x images.

# remove then store raw files.
analysis.raw_output_files.all().delete()
for name, put_location in result['raw_output_locations'].items():
content_type = 'application/octet-stream'
if name[-4:] == '.csv':
content_type = 'text/csv'
analysis.raw_output_files.add(store_file(put_location, content_type, initiator, filename=name))

@sambles sambles self-assigned this May 23, 2024
@sambles sambles changed the title Lot3 worker monitor compatilibty fix needed Lot3 worker monitor compatibility fix needed May 23, 2024
@sambles sambles changed the title Lot3 worker monitor compatibility fix needed Lot3 - worker monitor compatibility fix needed May 23, 2024
@awsbuild awsbuild added this to the 2.3.5 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants