-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peril code grouping #20
Comments
@tristanlloyd @benhayes21 Please could you add an example of the codes and the transformation direction requiring code splitting / direction requiring combination for this issue, to assist understanding the logic required to implement it in the mapping file. Thanks |
Previous feedback from Tristan: Trying to implement something like; transformation: 1 when: search(LayerPeril,‘PWH’) to split an AIR peril string like ‘PWH+PSH+PPH’ etc., to create separate peril columns with 1 or blanks (as required in our Sequel Impact Import). |
The best reference is https://docs.air-worldwide.com/Database/CEDE/9.0/topic137.html Is the best way to deal with this, to include the original and destination in the peril code listing, i.e. transform the grouped code to string in the same way as we transform a single code to a single code (is any other logic actually needed? |
Spliting these into multiple transformations is the way to go here, something like
is correct, is this not working? The reason this wouldn't work
is that the first argument to |
Running this on a basic test does not appear to work as expected. Requires tests to confirm correct structuring of transformation using multiple where clauses, and documentation of how to perform these types of conditional statements with clear examples. Issues found in running tests using the one-way-transformation:
Running the following, the transformation succeeds with no error, but only the 1st transformation is completed; second one is blank. Running the following, the transformation succeeds with no error, but all values in d return 99 |
Explore whether adjustment to mapping file can address problems found in testing, with handling grouped peril codes in one model format (AIR) and separate peril codes in another (OED).
Documentation should highlight this as a known issue for this translation.
The text was updated successfully, but these errors were encountered: