Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute env variables in prometheus.yml #289

Closed
KaloyanTanev opened this issue Sep 13, 2024 · 0 comments
Closed

Substitute env variables in prometheus.yml #289

KaloyanTanev opened this issue Sep 13, 2024 · 0 comments
Assignees
Labels
protocol protocol team tickets

Comments

@KaloyanTanev
Copy link
Contributor

KaloyanTanev commented Sep 13, 2024

🎯 Problem to be solved

Prometheus does not substitute environment variables by default. There is an option to do so only for variables external_labels. We have a $PROM_REMOTE_WRITE_TOKEN env var in the prometheus.yml file which is misleading, as it doesn't get expanded when prometheus is started.

🛠️ Proposed solution

We can run a custom script on start of the docker-compose, similarly to what we do with lodestar. There we can expand the variables and then start prometheus itself.

@github-actions github-actions bot added the protocol protocol team tickets label Sep 13, 2024
@KaloyanTanev KaloyanTanev transferred this issue from ObolNetwork/charon Sep 13, 2024
@KaloyanTanev KaloyanTanev self-assigned this Sep 13, 2024
KaloyanTanev added a commit that referenced this issue Sep 18, 2024
Evaluate env vars in `prometheus.yml`.

ticket: #289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol protocol team tickets
Projects
None yet
Development

No branches or pull requests

1 participant