Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DepositContract on ERC1155 mint #134

Open
cosminobol opened this issue May 14, 2024 · 0 comments
Open

Use DepositContract on ERC1155 mint #134

cosminobol opened this issue May 14, 2024 · 0 comments
Assignees

Comments

@cosminobol
Copy link
Contributor

cosminobol commented May 14, 2024

activeSupply should represent current supply (the amount of tokens the receiver has which is equal to 32 * amount ETH deposited into the DepositContract)
and
totalSupply is the max supply for that ERC1155 token
Given this context, I would rename totalSupply to maxSupply and activeSupply to totalSupply

  • redeem through ERC1155 the 32eth from OWR; check edge cases
@cosminobol cosminobol self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant