Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of polymorphism in the TypeRegistry #593

Open
Discolai opened this issue Jan 23, 2024 · 0 comments
Open

Extension of polymorphism in the TypeRegistry #593

Discolai opened this issue Jan 23, 2024 · 0 comments

Comments

@Discolai
Copy link

Your recent change to the TypeRegistry allowing polymorphism is a great addition, but we find its contraints a bit too limiting.

The current implementation requires types to be either abstract or interefaces in order to pick up derived types, but this is not always feasible. My suggestion is to introduce a HalibutPolymorphicAttribute and optionally HalibutDerivedTypeAttribute similar to how microsoft did it with System.Text.Json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant