Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReleaseNotes inside Deployment are nullable #171

Open
mac2000 opened this issue Feb 25, 2024 · 0 comments · May be fixed by #172
Open

ReleaseNotes inside Deployment are nullable #171

mac2000 opened this issue Feb 25, 2024 · 0 comments · May be fixed by #172

Comments

@mac2000
Copy link

mac2000 commented Feb 25, 2024

According to a interfaces it seems that ReleaseNotes should be non nullable string, but in reality it may be null

import { Client, DeploymentRepository } from '@octopusdeploy/api-client'

describe('repro', () => {
  it('has null release notes', async () => {
    const client = await Client.create({
      instanceURL: 'https://sample.octopus.app',
      apiKey: process.env.OCTOPUS_APIKEY,
      userAgentApp: 'sample',
    })
    const deployments = new DeploymentRepository(client, 'Sample')
    const deployment = await deployments.get('Deployments-1')
    expect(deployment.Changes).toHaveLength(1)
    expect(deployment.Changes[0].ReleaseNotes).toBe(null) // <- interfaces vs reality
  })
})
@mac2000 mac2000 linked a pull request Feb 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant